Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locate images of the rotating earth,sun and moon #10996

Merged
merged 1 commit into from Apr 12, 2023

Conversation

yanniser
Copy link
Contributor

@yanniser yanniser commented Jan 8, 2023

in the french version of the Canvas API tutorial, the rotating earth animation is broken because the images (present in the en version) are not found

I locate the image src to the english version

Related issues and pull requests

Fixes #10995

@yanniser yanniser requested a review from a team as a code owner January 8, 2023 09:23
@yanniser yanniser requested review from cw118 and removed request for a team January 8, 2023 09:23
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Jan 8, 2023
Copy link
Member

@SphinxKnight SphinxKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, both for the issue filing and most importantly for the PR proposing a fix.

This is an instance of mdn/yari#5652
While absolute URLs should work, I would prefer keeping the relative paths but copying the image files in the directory of the page.

This is a trade-off while mdn/yari#5652 is opened but it looks more elegant/robust to me.

If you need any help for doing that, please let me know!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Preview URLs

Flaws (10)

URL: /fr/docs/Web/API/Canvas_API/Tutorial/Basic_animations
Title: Animations basiques
Flaw count: 10

  • macros:
    • /fr/docs/Web/API/Window/setInterval does not exist but fell back to /en-US/docs/Web/API/setInterval
    • /fr/docs/Web/API/Window/setTimeout does not exist but fell back to /en-US/docs/Web/API/setTimeout
    • /fr/docs/Web/API/WindowTimers/setInterval does not exist but fell back to /en-US/docs/Web/API/setInterval
    • /fr/docs/Web/API/WindowTimers/setTimeout redirects to /fr/docs/Web/API/setTimeout
    • /fr/docs/Web/API/EventListener redirects to /fr/docs/Web/API/EventTarget/addEventListener
  • broken_links:
    • Can't resolve /fr/docs/Tutoriel_canvas/Advanced_animations
    • Can't resolve /fr/docs/Jeux/Anatomie
    • Can't resolve /fr/docs/Jeux
    • Can't resolve /fr/docs/Un_raycaster_basique_avec_canvas
  • translation_differences:
    • Differences in the important macros (1 in common of 8 possible)

@cw118
Copy link
Member

cw118 commented Apr 8, 2023

@yanniser Please don't hesitate if help or discussion is needed here :)

@SphinxKnight SphinxKnight merged commit fbbbeb5 into mdn:main Apr 12, 2023
5 checks passed
@SphinxKnight SphinxKnight added this to ✅ Done in l10n-fr Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
Projects
l10n-fr
  
✅ Done
Development

Successfully merging this pull request may close these issues.

In the french version of canvas tutorial , animation section , the images canvas_sun.png are not present
3 participants