Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unary operators #1385

Merged
merged 6 commits into from
Jul 12, 2021
Merged

Add unary operators #1385

merged 6 commits into from
Jul 12, 2021

Conversation

wisedog
Copy link
Contributor

@wisedog wisedog commented Jul 4, 2021

단항 부정 연산자, 단항 더하기 연산자 추가

회사 주니어 개발자가 단항 더하기 연산자로 형변환을 해서 신기해서 찾아보다가 번역하게 되었습니다.

@wisedog wisedog requested a review from a team as a code owner July 4, 2021 11:29
@wisedog wisedog requested review from hochan222 and removed request for a team July 4, 2021 11:29
@cos18 cos18 added the l10n-ko Issues related to Korean content. label Jul 4, 2021
hochan222
hochan222 approved these changes Jul 11, 2021
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요. @wisedog 님! 리뷰 드립니다.

PR을 읽으면서 많이 배웠습니다. 감사합니다.

기여해주셔서 감사합니다. 좋은 하루 보내세요 :)

files/ko/web/javascript/reference/operators/unary_negation/index.html Outdated Show resolved Hide resolved
files/ko/web/javascript/reference/operators/unary_negation/index.html Outdated Show resolved Hide resolved
files/ko/web/javascript/reference/operators/unary_plus/index.html Outdated Show resolved Hide resolved
files/ko/web/javascript/reference/operators/unary_plus/index.html Outdated Show resolved Hide resolved
files/ko/web/javascript/reference/operators/unary_plus/index.html Outdated Show resolved Hide resolved
hochan222
hochan222 requested changes Jul 11, 2021
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

wisedog and others added 2 commits July 12, 2021 22:19
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2021 •
edited

Preview URLs

Flaws

URL: /ko/docs/Web/JavaScript/Reference/Operators/Unary_negation
Title: 단항 부정 (-)
on GitHub
Flaw count: 6

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 1 more flaws omitted

URL: /ko/docs/Web/JavaScript/Reference/Operators/Unary_plus
Title: 단항 더하기 (+)
on GitHub
Flaw count: 6

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 1 more flaws omitted

External URLs

URL: /ko/docs/Web/JavaScript/Reference/Operators/Unary_negation
Title: 단항 부정 (-)
on GitHub

No new external URLs

URL: /ko/docs/Web/JavaScript/Reference/Operators/Unary_plus
Title: 단항 더하기 (+)
on GitHub

No new external URLs

(this comment was updated 2021-07-12 13:59:43.464409)

@wisedog wisedog requested a review from hochan222 July 12, 2021 13:59
hochan222
hochan222 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hochan222 hochan222 merged commit 9358d5b into mdn:main Jul 12, 2021
hochan222 added a commit that referenced this pull request Jul 18, 2021
@hochan222
docs: 역자주 번역 가이드 추가 (#1385)
dd2f33f
This was referenced Jul 18, 2021
Closed
Merged
hochan222 added a commit that referenced this pull request Jul 18, 2021
@hochan222 @wisedog @alattalatta
docs: 역자주 번역 가이드 추가 (#1385)
60bb6e5 
Co-authored-by: wisedog <kim.jongha@gmail.com>
Co-authored-by: alattalatta <urty5656@gmail.com>
hochan222 added a commit that referenced this pull request Jul 19, 2021
@hochan222 @cos18
@pje1740 @yujo11 @alattalatta @gidongkwon @wisedog
[ko] 가이드라인 추가 (#1588)
af76135 
* docs: add JS word list (#1081)

Co-authored-by: cos18 <codest99@gmail.com>
Co-authored-by: pje1740 <stitch.coding@gmail.com>
Co-authored-by: yujo11 <yujo.dev@gmail.com>
Co-authored-by: alattalatta <urty5656@gmail.com>
Co-authored-by: gidongkwon <lucidfext@gmail.com>
Co-authored-by: wisedog <kim.jongha@gmail.com>

* docs: 역자주 번역 가이드 추가 (#1385)

Co-authored-by: wisedog <kim.jongha@gmail.com>
Co-authored-by: alattalatta <urty5656@gmail.com>

* docs: add contact us

Co-authored-by: logic-finder <>

* refactor: 단어 분류만 알맞은 곳으로 변경

Co-authored-by: cos18 <codest99@gmail.com>
Co-authored-by: pje1740 <stitch.coding@gmail.com>
Co-authored-by: yujo11 <yujo.dev@gmail.com>
Co-authored-by: alattalatta <urty5656@gmail.com>
Co-authored-by: gidongkwon <lucidfext@gmail.com>
Co-authored-by: wisedog <kim.jongha@gmail.com>
@wisedog wisedog deleted the trans/unary-operators branch November 29, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alattalatta alattalatta alattalatta left review comments

@hochan222 hochan222 hochan222 approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wisedog @alattalatta @hochan222 @cos18