Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete conflicting/orphaned in ko #1423

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Jul 6, 2021

Ever since early spring 2021, we decided to not index the conflicting (and orphaned) documents but leave them in the repo. These documents will not be found by Google searching or our own internal site-search.
The original motive was to keep these around until each localization team has decided that the slug that should be kept is more up-to-date.

@peterbe peterbe requested a review from a team as a code owner July 6, 2021 17:32
@peterbe peterbe requested review from igy95 and removed request for a team July 6, 2021 17:32
@yujo11 yujo11 added the l10n-ko Issues related to Korean content. label Jul 7, 2021
@hochan222 hochan222 added this to 신규 이슈 in l10n-ko via automation Jul 7, 2021
@hochan222
Copy link
Member

hochan222 commented Jul 7, 2021

나에게 남기는 메모: 유사 내용의 대체된 페이지들 링크 찾기

@peterbe
Copy link
Contributor Author

peterbe commented Jul 7, 2021

@hochan222 If you think it's ready, can you review and merge?

@hochan222
Copy link
Member

hochan222 commented Jul 8, 2021

@peterbe I read Files Changed about half, but I have a question. Most of the conflicting documents were translated in 2013, and it is confirmed that the current version has been replaced. However, the content of the conflicting documents and the latest documents are completely different.

Is there any data(or history) I can refer to as to what caused these documents to be separated from the current documents?

Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

All were well replaced.

@@ -1,106 +0,0 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(a note just for me) check point for compare

@hochan222 hochan222 merged commit 0d13fee into mdn:main Jul 8, 2021
l10n-ko automation moved this from 신규 이슈 to ✅ Done Jul 8, 2021
@peterbe peterbe deleted the delete-conflictingorphaned-in-ko branch July 8, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
l10n-ko
✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants