Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] fix: Updates to Web/API/Element/*Attribute* pages #19512

Merged
merged 15 commits into from Apr 17, 2024

Conversation

quentin-rey
Copy link
Contributor

@quentin-rey quentin-rey commented Apr 14, 2024

Description

Some corrections and updates on Web/API/Element/*Attribute* pages.

These update were previously part of #19081. For better tracking, we have separated the {{DOMAttributeMethods}} macro deletion from the other updates.

Motivation

  • Improved readability
  • Deleting *xref macros and add links instead
  • Addition of "Parameters" and "Return values" sections to the parent "Syntax" section

Additional details

N/A

Related issues and pull requests

cc @SphinxKnight

@quentin-rey quentin-rey requested a review from a team as a code owner April 14, 2024 10:32
@quentin-rey quentin-rey requested review from SphinxKnight and removed request for a team April 14, 2024 10:32
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Apr 14, 2024
Copy link
Contributor

github-actions bot commented Apr 14, 2024

Preview URLs (12 pages)
Flaws (2)

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /fr/docs/Web/API/Element/removeAttributeNode
Title: Element : méthode removeAttributeNode()
Flaw count: 1

  • broken_links:
    • Can't resolve /fr/docs/Web/API/Document/removeAttribute

URL: /fr/docs/Web/API/Element/setAttribute
Title: Element : méthode setAttribute()
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)
External URLs (5)

URL: /fr/docs/Web/API/Element/setAttribute
Title: Element : méthode setAttribute()

(comment last updated: 2024-04-17 12:10:33)

files/fr/web/api/element/getattributenode/index.md Outdated Show resolved Hide resolved
files/fr/web/api/element/getattributenode/index.md Outdated Show resolved Hide resolved
files/fr/web/api/element/getattributenodens/index.md Outdated Show resolved Hide resolved
files/fr/web/api/element/removeattributenode/index.md Outdated Show resolved Hide resolved
files/fr/web/api/element/setattributenode/index.md Outdated Show resolved Hide resolved
files/fr/web/api/element/setattributenode/index.md Outdated Show resolved Hide resolved
files/fr/web/api/element/setattributens/index.md Outdated Show resolved Hide resolved
files/fr/web/api/element/setattributens/index.md Outdated Show resolved Hide resolved
files/fr/web/api/element/setattributens/index.md Outdated Show resolved Hide resolved
@SphinxKnight SphinxKnight self-assigned this Apr 15, 2024
@leon-win leon-win changed the title fix: Updates to Web/API/Element/*Attribute* pages [fr] fix: Updates to Web/API/Element/*Attribute* pages Apr 15, 2024
Copy link
Member

@SphinxKnight SphinxKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK pour moi, j'ai ouvert quentin-rey#4 pour saisir l'opportunité de compléter les mises à jour

Update whole pages vs current en-US state
@SphinxKnight SphinxKnight merged commit 2a36c8e into mdn:main Apr 17, 2024
7 checks passed
@quentin-rey quentin-rey deleted the fr_minor_fixes_and_changes branch April 17, 2024 12:58
ciyoe pushed a commit to ciyoe/translated-content that referenced this pull request Apr 20, 2024
* fix: remove {{DOMAttributeMethods}} macro
+ add/update Specifications section
+ add/update Compat section
+ add/update See also section

* Keep old title for now

* Update Spécifications title section

* fix: flaws

* Update Specifications

* fix: change *xref to links

* fix: flaws

* fix: remove "Résumé" title

* update: Syntax section

* fix: flaws

* fix: flaws

* fix: flaws for list

* Update whole pages vs current en-US state

---------

Co-authored-by: SphinxKnight <SphinxKnight@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants