Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: update the translation of the MessageChannel section #19689

Merged
merged 3 commits into from
May 20, 2024
Merged

[zh-cn]: update the translation of the MessageChannel section #19689

merged 3 commits into from
May 20, 2024

Conversation

T34-active
Copy link
Contributor

Description

Motivation

Additional details

Related issues and pull requests

@T34-active T34-active requested a review from a team as a code owner April 23, 2024 09:20
@T34-active T34-active requested review from jasonren0403 and removed request for a team April 23, 2024 09:20
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Apr 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited

Preview URLs

External URLs (3)

URL: /zh-CN/docs/Web/API/MessageChannel
Title: MessageChannel

URL: /zh-CN/docs/Web/API/MessageChannel/port2
Title: MessageChannel：port2 属性

URL: /zh-CN/docs/Web/API/MessageChannel/MessageChannel
Title: MessageChannel：MessageChannel() 构造函数

(comment last updated: 2024-05-06 03:39:03)

skyclouds2001
skyclouds2001 reviewed Apr 24, 2024
View reviewed changes
files/zh-cn/web/api/messagechannel/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/messagechannel/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/messagechannel/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/port1/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/port2/index.md Outdated Show resolved Hide resolved
@yin1999 yin1999 changed the title [zh-cn]: init translation of messagechannel [zh-cn]: update the translation of the MessageChannel section Apr 25, 2024
@jasonren0403 jasonren0403 added the needs content update Needs update to the content to support this change. label Apr 25, 2024
@T34-active @skyclouds2001
Apply suggestions from code review
29dd1cd 
Co-authored-by: skyclouds2001 <95597335+skyclouds2001@users.noreply.github.com>
jasonren0403
jasonren0403 reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

除了上游的改动外，一些建议如下

files/zh-cn/web/api/messagechannel/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/messagechannel/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/messagechannel/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/port2/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/port1/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/port2/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/messagechannel/port2/index.md Outdated Show resolved Hide resolved
@T34-active @jasonren0403
Apply suggestions from code review
a5203c8 
Co-authored-by: Jason Ren <40999116+jasonren0403@users.noreply.github.com>
@T34-active T34-active marked this pull request as draft May 8, 2024 02:58
@T34-active T34-active marked this pull request as ready for review May 17, 2024 05:57
@T34-active
Copy link
Contributor Author

/cc @jasonren0403 已关闭上游更新 请你看看还有哪些内容需要改动

jasonren0403
jasonren0403 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sorry for long wait

@jasonren0403 jasonren0403 merged commit 2a27eb2 into mdn:main May 20, 2024
7 checks passed
@T34-active T34-active deleted the messageChannel_20240423 branch May 21, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonren0403 jasonren0403 jasonren0403 approved these changes

@skyclouds2001 skyclouds2001 Awaiting requested review from skyclouds2001

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content. needs content update Needs update to the content to support this change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@T34-active @jasonren0403 @skyclouds2001