Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] replace APIRef("XMLHttpRequest") macro calls with "XMLHttpRequest API" param #19703

Merged
merged 1 commit into from Apr 28, 2024
Merged

[ko] replace APIRef("XMLHttpRequest") macro calls with "XMLHttpRequest API" param #19703

merged 1 commit into from Apr 28, 2024

Conversation

leon-win
Copy link
Member

Description

This PR replaces all APIRef("XMLHttpRequest") macro calls with more suitable (XMLHttpRequest API) param for ko locale.

Also added {{AvailableInWorkers}} where necessary.

Related issues and pull requests

Relates to mdn/content#30070, mdn/content#30081

@leon-win leon-win requested a review from a team as a code owner April 23, 2024 16:08
@leon-win leon-win requested review from hochan222 and removed request for a team April 23, 2024 16:08
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Apr 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs (11 pages)
Flaws (39)

URL: /ko/docs/Web/API/FormData
Title: FormData
Flaw count: 3

  • macros:
    • /ko/docs/Web/API/XMLHttpRequest/send does not exist but fell back to /en-US/docs/Web/API/XMLHttpRequest/send
  • broken_links:
    • Can't resolve /ko/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/Web/API/FormData/Using_FormData_Objects

URL: /ko/docs/Web/API/FormData/getAll
Title: FormData.getAll()
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /ko/docs/Web/API/FormDataEntryValue does not exist but fell back to /en-US/docs/Web/API/FormData
  • broken_links:
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects

URL: /ko/docs/Web/API/FormData/delete
Title: FormData.delete()
Flaw count: 2

  • broken_links:
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects

URL: /ko/docs/Web/API/FormData/has
Title: FormData.has()
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects

URL: /ko/docs/Web/API/FormData/values
Title: FormData.values()
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects

URL: /ko/docs/Web/API/FormData/get
Title: FormData.get()
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /ko/docs/Web/API/FormDataEntryValue does not exist but fell back to /en-US/docs/Web/API/FormData
  • broken_links:
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects

URL: /ko/docs/Web/API/FormData/entries
Title: FormData.entries()
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects

URL: /ko/docs/Web/API/FormData/FormData
Title: FormData()
Flaw count: 3

  • broken_links:
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects
  • translation_differences:
    • Differences in the important macros (4 in common of 5 possible)

URL: /ko/docs/Web/API/FormData/keys
Title: FormData.keys()
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects

URL: /ko/docs/Web/API/FormData/append
Title: FormData.append()
Flaw count: 4

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects

URL: /ko/docs/Web/API/FormData/set
Title: FormData.set()
Flaw count: 5

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/Using_XMLHttpRequest
    • Can't resolve /ko/docs/DOM/XMLHttpRequest/FormData/Using_FormData_Objects

hochan222
hochan222 approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

Have a good weekend :)

@hochan222 hochan222 merged commit f437c67 into mdn:main Apr 28, 2024
6 checks passed
@leon-win leon-win deleted the fix/ko-xmlhttprequest-api-sidebar branch April 28, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hochan222 hochan222 hochan222 approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leon-win @hochan222