Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] new translation & fix Incorrect description of arrow function #2336

Merged
merged 1 commit into from Sep 13, 2021

Conversation

Juyeong-Byeon
Copy link
Contributor

before

In current document, It said "이 함수 표현은 메소드 함수가 아닌 곳에 가장 적합합니다. 그래서 생성자로서 사용할 수 없습니다."
It means
" This function expression is best suited for non-method functions. That's why you can't use it as a constructor."
But it is not.
As I know Arrow function does not have a prototype that's why it can't be used as a constructor.
this translation needs to be fixed.
And some of the information was not translated into Korean

after

  • Invalid information about Arrow function was removed.
  • Added omitted information.

[related issue]

before

In current document, It said "이 함수 표현은 메소드 함수가 아닌 곳에 가장 적합합니다. 그래서 생성자로서 사용할 수 없습니다."
It means
" This function expression is best suited for non-method functions. That's why you can't use it as a constructor."
But it is not.
As I know Arrow function does not have a prototype that's why it can't be used as a constructor.
this translation needs to be fixed.
And some of the information was not translated into Korean

after

* Invalid information about Arrowfunction was removed.
* Added omitted information.
@Juyeong-Byeon Juyeong-Byeon requested a review from a team as a code owner September 5, 2021 01:41
@Juyeong-Byeon Juyeong-Byeon requested review from igy95 and removed request for a team September 5, 2021 01:41
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Sep 5, 2021
@igy95
Copy link
Member

igy95 commented Sep 5, 2021

@wndudqus 안녕하세요! Preview URL도 같이 올려주시면 더 빠르게 확인할 수 있을 것 같아요. ☺️ 예시

@Juyeong-Byeon
Copy link
Contributor Author

@GwangYeol-Im 혹시 preview를 생성하는데 참고할 수 있는 문서가 있을까요?
알려주시면 감사하겠습니다!

@Juyeong-Byeon
Copy link
Contributor Author

@GwangYeol-Im 최초 PR이라서 workflow실행이 불가능해서 previwe 링크가 되지 않은 것 같은데, 허용부탁드립니다. 허용해주시면 preview 링크 첨부하겠습니다!

@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /ko/docs/Web/JavaScript/Reference/Functions/Arrow_functions
Title: 화살표 함수
on GitHub
Flaw count: 19

  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/this
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/super
    • Can't resolve https://developer.mozilla.org/en-US/docs/Glossary/Method
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/call
    • and 5 more flaws omitted
  • bad_pre_tags:
    • <pre><code>CODE can be just <pre>CODE
    • <pre><code>CODE can be just <pre>CODE
    • <pre><code>CODE can be just <pre>CODE
    • <pre><code>CODE can be just <pre>CODE
    • <pre><code>CODE can be just <pre>CODE
    • and 3 more flaws omitted
  • translation_differences:
    • Differences in the important macros (2 in common of 5 possible)

External URLs

URL: /ko/docs/Web/JavaScript/Reference/Functions/Arrow_functions
Title: 화살표 함수
on GitHub

No new external URLs

@igy95
Copy link
Member

igy95 commented Sep 13, 2021

@wndudqus github actions 이라 제가 하면 되는 거였군요 ㅎㅎ.. 확인 마쳤습니다 기여 감사합니다!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants