New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the list of observed attributes #10

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@LordRegentTB
Contributor

LordRegentTB commented Oct 8, 2018

In the life-cycle-callbacks example, the static get observedAttributes() function was returning attributes w and l, but the custom element actually uses c and l; thus, an update to the color would not be observed.

@chrisdavidmills

This comment has been minimized.

Contributor

chrisdavidmills commented Oct 9, 2018

Good catch — thanks for that!

@chrisdavidmills chrisdavidmills merged commit 31f6163 into mdn:master Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment