Update example of web component #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation along with the best practices says to move some of the constructing logic to the `connectedCallback` - this PR adjusts the example accordingly.
ralyodio
approved these changes
May 20, 2023
Closed
|
Closing this as a duplicate of #54 |
|
Sorry I was too quick to close, there are some other changes to review here :) |
|
This seems preferable to what #54 does — and probably should be merged instead (and #54 should be closed). But @gullerya if we do this, the corresponding code in the https://developer.mozilla.org/en-US/docs/Web/API/Web_components/Using_custom_elements article itself should also be updated. Would you be willing to open PR for doing that? |
This was referenced Aug 11, 2023
Closed
|
This is superseded by #62. |
|
Looks like this is resolved in the linked PR, so I am closing now. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation along with the best practices says to move some of the constructing logic to the
connectedCallback- this PR adjusts the example accordingly.Summary
Supporting details
Related issues
Related content pull request