This repository has been archived by the owner on Sep 11, 2022. It is now read-only.
Update speech-color-changer to be compatible with Safari #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari does not currently implement webkitSpeechGrammarList and throws an error at line 2. I have guarded against this, so the script now works in Safari on desktop and iPhone. I've also added a comment around the grammar code because no browser currently supports them, as noted in this WICG discussion: WICG/speech-api#57 Since we'll check usage stats to determine if grammars should be removed from the spec, and this script encourages grammar usage (I imagine this code will be copy/pasted assuming they have an effect), I added a comment to discourage their use. I didn't want to remove grammars completely, as this script is used as a demonstration of the spec on MDN.
| @@ -1,14 +1,18 @@ | |||
| var SpeechRecognition = SpeechRecognition || webkitSpeechRecognition | |||
| var SpeechGrammarList = SpeechGrammarList || webkitSpeechGrammarList | |||
| var SpeechGrammarList = SpeechGrammarList || window.webkitSpeechGrammarList | |||
There was a problem hiding this comment.
This looks like a mistake to me. Did you meant to fix the line above?
var SpeechRecognition = SpeechRecognition || webkitSpeechRecognition || window.webkitSpeechRecognition
There was a problem hiding this comment.
no, but we could fix it there too. Safari is missing webkitSpeechGrammarList and so throws an error unless you check the property on window. It wasn't missing webkitSpeechRecognition in the version I tested so I didn't see an error there.
| var speechRecognitionList = new SpeechGrammarList(); | ||
| speechRecognitionList.addFromString(grammar, 1); | ||
| recognition.grammars = speechRecognitionList; | ||
| if (SpeechGrammarList) { |
There was a problem hiding this comment.
I like this so it could run on Safari too.
schalkneethling
approved these changes
Jun 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari does not currently implement webkitSpeechGrammarList and throws an error at line 2.
I have guarded against this, so the script now works in Safari on desktop and iPhone.
I've also added a comment around the grammar code because no browser currently supports them, as noted in this WICG discussion:
WICG/speech-api#57
Since we'll check usage stats to determine if grammars should be removed from the spec, and this script encourages grammar usage (I imagine this code will be copy/pasted assuming they have an effect), I added a comment to discourage their use.
I didn't want to remove grammars completely, as this script is used as a demonstration of the spec on MDN.