Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decodeAudioData() examples aligned for clean diff #109

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

sidewayss
Copy link
Contributor

Now the two decodeAudioData() examples align for a clean diff between them. The only changes to the XHR example are in the comments. This should be the last of my changes to these two files for the foreseeable future.
Now I can complete the docs PR changes.

Now the two decodeAudioData() examples align for a clean diff between them.
@sidewayss
Copy link
Contributor Author

My review items clean up comment text in both examples. Those changes to comments are reflected in the docs PR here: mdn/content#27185
I have set up github pages for this branch here: https://sidewayss.github.io/webaudio-examples/
The matching pair of updates to docs and live examples is ready for final review.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jul 7, 2023
@sideshowbarker sideshowbarker merged commit 5da84bf into mdn:main Jul 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants