Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beastify doesn't work with Firefox 45.0a2 (2016-01-03) #21

Closed
arnaud-jacquemin opened this issue Jan 3, 2016 · 5 comments
Closed

Beastify doesn't work with Firefox 45.0a2 (2016-01-03) #21

arnaud-jacquemin opened this issue Jan 3, 2016 · 5 comments

Comments

@arnaud-jacquemin
Copy link

Hello,

When I run the "Beastify" addon on Firefox Developer Edition 45.0a2 (2016-01-03), the "paw" icon is there, it opens the popup with 3 buttons, but nothing happens when I click these buttons.

Looking at my OS console, I found this messages :

Extension error: Error opening input stream (invalid filename?): moz-extension://b4f0c458-8e3b-4aa8-bb3c-5ff7d692969b/popup/content_scripts/beastify.js undefined undefined
[[Exception stack
undefinedCurrent stack
runSafeSyncWithoutClone@resource://gre/modules/ExtensionUtils.jsm:25:110
tryInject@resource://gre/modules/ExtensionContent.jsm:191:9
execute@resource://gre/modules/ExtensionContent.jsm:267:5
executeScript@resource://gre/modules/ExtensionContent.jsm:387:5
receiveMessage@resource://gre/modules/ExtensionContent.jsm:590:9
]]

The addon now works if I change a line in the popup/choose_beast.js source code, from :

  chrome.tabs.executeScript(null, {
    file: "content_scripts/beastify.js" 
  });

to :

  chrome.tabs.executeScript(null, {
    file: "../content_scripts/beastify.js" 
  });

I don't know if it's a Firefox bug or a typo in the Beastify source code ?

Thank you in advance

@rpl
Copy link
Member

rpl commented Jan 4, 2016

@wbamberg @arnaud-jacquemin it looks like a Firefox bug (I tried on a Chromium based browser and it works correctly, and it fails if the workaround is applied)

I've filed it here: https://bugzilla.mozilla.org/show_bug.cgi?id=1236500

@wbamberg
Copy link

wbamberg commented Jan 4, 2016

Thanks @rpl ! I'll leave this open until the fix is in Nightly and we have verified that it works.

@wbamberg
Copy link

wbamberg commented Jan 5, 2016

I've implemented the workaround for now: 315084c and will take it out when the bug is fixed.

@arnaud-jacquemin
Copy link
Author

Thank you guys!

@wbamberg
Copy link

wbamberg commented Jan 6, 2016

Fixed by #26. Thanks @rpl and @arnaud-jacquemin .

@wbamberg wbamberg closed this as completed Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants