cross browser workaround for chrome.tabs.executeScripts and minor style tweaks #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wbamberg I've just tried the "beastify" example on Iridium (a Chrome based browser) and it doesn't work because of the different url resolution. How about using an explicit absolute url which works on both Firefox and Chrome? |
wbamberg
pushed a commit
that referenced
this pull request
Jan 6, 2016
cross browser workaround for chrome.tabs.executeScripts and minor style tweaks
|
Works great, thanks @rpl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current workaround applied on chrome.tabs.executeScript does not work on Chromium-based browsers.
This PR use an explicit absolute url which works on both Firefox and Chrome (and some minor tweaks on the stylesheet applied to the popup page)