-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update native-messaging to use python3, clarify instructions #564
base: main
Are you sure you want to change the base?
Conversation
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
@rebloor, at your suggestion I took a look at the native-messaging example and also wasn't able to get it to run locally on my test device using the instructions provided. Please take a look at the updated instructions and revise as appropriate. |
Thanks @dotproto I'll take a look first thing next week |
Co-authored-by: Rob Wu <rob@robwu.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for your consideration. I'll test the code tomorrow.
Co-authored-by: rebloor <git@sherpa.co.nz>
Description
The following updates were made to the
native-messaging
example.app/ping_pong.py
explicitly use Python 3 instead of Python 2app/ping_pong_win.bat
runner to use Python 3 (untested)app/
with the full paths of the files they referenceport.onDisconnect
listener toadd-on/background.js
Motivation
Update the example to function as expected.
Additional details
N/A
Related issues and pull requests
Fixes #560