Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webextension panel does not auto-resize according to the URLs length #90

Closed
vasilicatamas opened this issue Sep 6, 2016 · 9 comments
Closed
Labels
good first issue A good issue for newcomers to get started with.

Comments

@vasilicatamas
Copy link

Steps to reproduce:
1.Install the following webextension as a temporary add-on:
history-deleter.zip
2.Navigate a bit through google images in order to gather some browsing history.

Expected results:
The entire content is correctly displayed in the panel.

Actual results:
When the URLs are too long the webextension panel does not auto-resize according to the links length and the last 5 visited sites are not entirely displayed.

Additional notes:

  • This issue reproduces on Firefox 51.0a1 (2016-09-05) and Firefox 50.0a2 (2016-09-05) under Windows 10 64-bit.
  • Please see the attached screenshot:
    2016-09-06_1701
@andymckay
Copy link

Yeah that's not great but I wanted to keep the add-on really simple and the focus of the add-on is on the history deleter API not on the length. Saying that if, someone wanted to send a really simple pull request that fixed this, that would be cool.

@kartik95
Copy link
Contributor

Fixed the bug. Pull request #101

@kartik95
Copy link
Contributor

Will my PR be merged anytime soon? Or does it need any changes? @andymckay
I request you to please add 'hacktoberfest' label to this issue before merging. It would really help me. Thanks!

@wbamberg
Copy link

Fixed by #101.

@wbamberg wbamberg reopened this Oct 13, 2016
@wbamberg
Copy link

@vasilicamihasca , could you verify the fix, please?

@vasilicatamas
Copy link
Author

I am still able to reproduce this issue on Firefox 51.0a2 (2016-10-14) under Windows 10 64-bit.

2016-10-14_1848

I am not sure but it might be a regression here. Because I noticed that on Firefox 49.0.1 successfully appears a scrollbar and the URL’s are correctly displayed.

2016-10-14_1853_001

@wbamberg
Copy link

Yes, I see this too. I think we should file a Firefox bug for this. @vasilicamihasca , since you found it, do you mind filing?

@vasilicatamas
Copy link
Author

@wbamberg
Copy link

Thanks @vasilicamihasca ! Since this is confirmed as a Firefox bug, we can close this. Thanks also @kartik95 for improving the look of the panel in the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good issue for newcomers to get started with.
Projects
None yet
Development

No branches or pull requests

5 participants