Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add setup-node + npm ci to lint workflow #548

Merged
merged 1 commit into from
Oct 31, 2023
Merged

chore: add setup-node + npm ci to lint workflow #548

merged 1 commit into from
Oct 31, 2023

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Oct 31, 2023

Fixup as follow-up to #532

Currently, any PR fails with:

Run reviewdog/action-eslint@v1
Run $GITHUB_ACTION_PATH/script.sh
馃惗 Installing reviewdog ... https://github.com/reviewdog/reviewdog
sh: 1: eslint: not found
Running npm install to install eslint ...
eslint version:v8.52.0
Running eslint with reviewdog 馃惗 ...
Error: Process completed with exit code 1.

@Rob--W Rob--W requested a review from rebloor October 31, 2023 21:27
@rebloor rebloor merged commit fc984fa into mdn:main Oct 31, 2023
3 checks passed
@Rob--W Rob--W mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebloor rebloor rebloor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rob--W @rebloor