Illustrative function name #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updateActiveTab has ambiguous meaning, most prominent of which doesn't mean what we are actually trying to do.
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
github-actions
bot
added
the
idle
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateActiveTab has ambiguous meaning, most prominent of which doesn't mean what we are actually trying to do.
Description
updateActiveTab has ambiguous meaning, most prominent interpretation of which is not what we are actually doing in the function body.
Motivation
I know JS as server-side engineer (we have very pedantic rules on where we are allowed to change state), in this succinct but cool sample code, the flow-of-control is slightly confusing (if we don't know browser event loop) and I guess descriptive function names would reduced the confusion for new comers, the author had context and experience, but for newbies updateActiveTab would mean perhaps we are modifying something on page. Reading function def would clear the misconception, but add mental burden.
Additional details
Related issues and pull requests