Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illustrative function name #561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Illustrative function name #561

wants to merge 1 commit into from

Conversation

s-c-p
Copy link

@s-c-p s-c-p commented May 11, 2024

updateActiveTab has ambiguous meaning, most prominent of which doesn't mean what we are actually trying to do.

Description

updateActiveTab has ambiguous meaning, most prominent interpretation of which is not what we are actually doing in the function body.

Motivation

I know JS as server-side engineer (we have very pedantic rules on where we are allowed to change state), in this succinct but cool sample code, the flow-of-control is slightly confusing (if we don't know browser event loop) and I guess descriptive function names would reduced the confusion for new comers, the author had context and experience, but for newbies updateActiveTab would mean perhaps we are modifying something on page. Reading function def would clear the misconception, but add mental burden.

Additional details

Related issues and pull requests

updateActiveTab has ambiguous meaning, most prominent of which doesn't mean what we are actually trying to do.
Copy link

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant