Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run scheduled workflows on forks #3229

Closed
SphinxKnight opened this issue Mar 15, 2021 · 6 comments
Closed

Don't run scheduled workflows on forks #3229

SphinxKnight opened this issue Mar 15, 2021 · 6 comments
Assignees

Comments

@SphinxKnight
Copy link
Member

I've forked this repo and received daily updates about failed actions on my repository (namely, pushing to production failed :))
A quick solution for this is to disable the actions on the fork.
I think it would be useful to add a quick note about this in the Readme.

I'll suggest a PR later.

@peterbe
Copy link
Contributor

peterbe commented Mar 15, 2021

Good point! I also think it's a waste of electricity that every individual's fork would be running CI.

I'm not entirely sure how to get to your Action runs. (Or mine, or Ryan's, etc.)
I think what we should do is make sure the cronjobs only run if the repository owner is mdn.

@peterbe peterbe changed the title Readme: Add a note about disabling GitHub Actions on forks Don't run scheduled workflows on forks Mar 15, 2021
@peterbe peterbe self-assigned this Mar 15, 2021
@peterbe
Copy link
Contributor

peterbe commented Mar 15, 2021

What I don't yet understand is; how do you even see what Actions are running in a fork? On forks, you don't even have the "Actions" tab. If I take the mdn on's URL and just replace the mdn with SphinxKnight I get a 404: https://github.com/SphinxKnight/yari/actions

From what I can gather, people will have to manually click into their "Settings" (on their fork) and disable Actions. Gross. https://github.community/t/stop-github-actions-running-on-a-fork/17965 Who's going to read that?
Let's see about disabling all scheduled workflows unless their the main repo.

peterbe added a commit to peterbe/yari that referenced this issue Mar 15, 2021
@peterbe
Copy link
Contributor

peterbe commented Mar 15, 2021

@SphinxKnight I'm actually very confused now.
What Actions do you have in https://github.com/SphinxKnight/yari ?
What are your "Actions" setting set to? I.e. on your https://github.com/SphinxKnight/yari/settings/actions

Does anybody else get notifications about failed production builds from Yari that isn't from running inside mdn/yari?
@escattone @fiji-flo

@SphinxKnight
Copy link
Member Author

SphinxKnight commented Mar 15, 2021

A screenshot might be worth a 1000words so here goes:
image

I disabled them via the settings this morning (UTC+1) with the option ("Disable Actions") but before that the default was "Allow all actions"

@escattone
Copy link
Contributor

@peterbe I just went through my forks and saw that I had not yet disabled Actions on all of them (so I did that).

escattone pushed a commit that referenced this issue Mar 15, 2021
@SphinxKnight
Copy link
Member Author

Closed as per #3245 if I understand correctly.

peterbe added a commit to peterbe/yari that referenced this issue Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants