Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skip prototype keyword during search #7859

Closed
NiedziolkaMichal opened this issue Dec 22, 2022 · 2 comments · Fixed by #7866
Closed

Allow skip prototype keyword during search #7859

NiedziolkaMichal opened this issue Dec 22, 2022 · 2 comments · Fixed by #7866
Labels
has PR Issues that already have a PR p3 We don't have visibility when this will be addressed. 🔎 search Search feature ux make the user experience awesome

Comments

@NiedziolkaMichal
Copy link
Member

Sometimes it's annoying, that the correct search result is not shown, just because the method or property that I am looking for, has the prototype keyword inside. For example, when I want to find get method from Map object, I will write: Map. to see all fields from Map and then start writing .g to see all fields starting with a g letter. At this point, all I can see are 4 search items, unrelated to my request.
I think it would be better, if the keyword prototype would be treated specially, allowing it to be omitted in such search requests.

@caugner caugner added p3 We don't have visibility when this will be addressed. ux make the user experience awesome 🔎 search Search feature and removed needs-triage labels Dec 22, 2022
@caugner
Copy link
Contributor

caugner commented Dec 22, 2022

I agree that this is annoying. A workaround is to search for Map get with a space instead of a dot.

A simple solution would be to preprocess the search query by replacing . with . (or splitting at whitespace and before a dot), which would cause Map and .get to be treated as different query terms.

@caugner caugner added the has PR Issues that already have a PR label Dec 23, 2022
@caugner
Copy link
Contributor

caugner commented Dec 23, 2022

@NiedziolkaMichal Feel free to review my PR that should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR Issues that already have a PR p3 We don't have visibility when this will be addressed. 🔎 search Search feature ux make the user experience awesome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants