fix(playground): dispatch readystatechange + bubble DOMContentLoaded on document #10946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
caugner
changed the title
mostafaroshdy1
pushed a commit
to mostafaroshdy1/yari
that referenced
this pull request
Apr 19, 2024
…on document (mdn#10946) fix(playground): dispatch readystatechange event fix(playground): dispatch DOMContentLoaded event on document + bubble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10766.
Fixes #10771.
Problem
The Playground doesn't dispatch a
readystatechangeevent, and only dispatches theDOMContentLoadedon thewindow, not on thedocument, so event listeners on thedocumentaren't called.Solution
readystatechangeevent (once betweenDOMContentLoadedandload, becausedocument.readyStatewill already becompleted.)DOMContentLoadedondocumentand let it bubble.(Kudos to @Kaiido for the proposing this solution.)
Screenshots
Before
After
How did you test this change?
Deployed to stage and verified that it works as expected on https://developer.allizom.org/en-US/docs/web/api/document/readystatechange_event#result.