Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): use "noindex, follow" robots tag + remove robots.txt exclude #11140

Merged
merged 3 commits into from
May 27, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 16, 2024

Summary

(MP-1108)

⚠️ Requires #11139 to be merged first.

Problem

The full-text search pages are excluded via robots.txt, but their robots tag still indicates index, follow.

Solution

Update the robots tag to noindex, follow, and remove the exclusion from the robots.txt.


How did you test this change?

  1. Added BUILD_ALWAYS_ALLOW_ROBOTS=true to my .env file.
  2. Ran yarn build:prepare.
  3. Verified that client/build/en-us/search/index.html has a robots tag with value noindex, follow.
  4. Verified that client/build/robots.txt no longer has exclusion rules for /*/search.

@caugner caugner force-pushed the MP-1108-set-noindex-follow-for-search branch from 7a9cc00 to 3ae79b5 Compare May 16, 2024 03:52
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 16, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Previously, it was "index, follow", but we do not want to index
MDN full-text search results.
@caugner caugner force-pushed the MP-1108-set-noindex-follow-for-search branch from 3ae79b5 to f844aab Compare May 17, 2024 18:31
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 17, 2024
@caugner caugner marked this pull request as ready for review May 17, 2024 18:33
@caugner caugner requested a review from a team as a code owner May 17, 2024 18:33
@caugner caugner merged commit 734c0b6 into main May 27, 2024
13 checks passed
@caugner caugner deleted the MP-1108-set-noindex-follow-for-search branch May 27, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants