-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloud-function): redirect non-canonical URLs #11151
Open
caugner
wants to merge
8
commits into
main
Choose a base branch
from
MP-1111-redirect-capitalization
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
redirects
all things related to redirecting
cloud-function
labels
May 17, 2024
fiji-flo
reviewed
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a way that doesn't add another fetch please?
This reverts commit 1c76989.
1. Build `sitemap.txt`, with all pages from all sitemaps. 2. Build `sitemap.json` for the Cloud Function, similar to the `redirects.json`. 3. Use middleware to redirect all URLs that match after normalization.
Here's my second approach, utilizing a global sitemap. |
caugner
changed the title
feat(cloud-function): redirect capitalization
feat(cloud-function): redirect non-canonical URLs
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1111)
Problem
We currently serve the same content independent of capitalization:
Solution
Fetch the
metadata.json
and match the URL (excluding search parameters) against themdn_url
in it.How did you test this change?
npm ci && npm start
in/cloud-function
.http://localhost:5100/en-US/docs/web?foo=bar
redirects tohttp://localhost:5100/en-US/docs/Web?foo=bar
.