Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add Japanese translation for Games section #11152

Merged
merged 1 commit into from
May 20, 2024

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented May 18, 2024

Summary

@hmatrjp @potappo , mdn-yari-ja

please review for this pull request

Problem

still en-us only

English pages

スクリーンショット 2024-05-18 13 26 31

Japanese pages

スクリーンショット 2024-05-18 13 26 58

Solution

translate japanese for LearnSidebar.ejs

NOTICE

@caugner, @wbamberg , @schalkneethling

Please merge once mdn-yari-ja is approved.

Before

still en-us only

After

add tranlate japanese for LearnSidebar.ejs

Copy link
Contributor

@potappo potappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web はウェブでお願いします。

@gurezo
Copy link
Contributor Author

gurezo commented May 18, 2024

@potappo

Web はウェブでお願いします。

修正しました!
6cb40d8

Copy link
Contributor

@potappo potappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@gurezo
Copy link
Contributor Author

gurezo commented May 18, 2024

@caugner, @wbamberg , @schalkneethling

already approved by mdn-yari-ja (@potappo)
please this PR review

@caugner caugner changed the title chore(translate):side menu for add section and translate section chore(macros/LearnSidebar): add Japenese translation for Games section May 20, 2024
@caugner caugner changed the title chore(macros/LearnSidebar): add Japenese translation for Games section chore(macros/LearnSidebar): add Japanese translation for Games section May 20, 2024
@caugner caugner merged commit 10d50be into mdn:main May 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants