feat(curriculum): update curriculum #11426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
requested changes
Jul 8, 2024
caugner
changed the title
caugner
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Nit: It would be better to name these fullscreen-{enter,exit}.svg so they're next to each other.
| .curriculum-partner-banner-container { | ||
| .partner-banner { | ||
| background-color: var(--curriculum-bg-color-partner); | ||
| background-image: var(--curriculum-partner-bg); |
There was a problem hiding this comment.
Nit: --curriculum-bg-image-partner would be a better name, to be consistent with --curriculum-bg-color-partner, and to avoid confusion with other -bg- variables omitting -color- that refer to a color.
Suggested change
| background-image: var(--curriculum-partner-bg); | |
| background-image: var(--curriculum-bg-image-partner); |
client/src/curriculum/scrim.scss
Outdated
| align-items: center; | ||
| display: flex; | ||
| flex-direction: column; | ||
| grid-area: scrim; |
There was a problem hiding this comment.
Nit: The assignment to the grid-area would make more sense to do in the parent component's CSS.
client/src/curriculum/scrim.tsx
Outdated
| dialog.current?.close(); | ||
| setShowDialog(false); | ||
| gleanClick( | ||
| `${CURRICULUM_PARTNER}: landing_page_scrim_exit_fullscreen` |
There was a problem hiding this comment.
Nit: landing_page can be derived from the current page url.
Suggested change
| `${CURRICULUM_PARTNER}: landing_page_scrim_exit_fullscreen` | |
| `${CURRICULUM}: scrim fullscreen -> 0` |
client/src/curriculum/scrim.tsx
Outdated
| import { ReactComponent as EnterFullscreen } from "../../public/assets/curriculum/enter-fullscreen.svg"; | ||
|
|
||
| import "./scrim.scss"; | ||
| import { CURRICULUM_PARTNER } from "../telemetry/constants"; |
There was a problem hiding this comment.
Suggested change
| import { CURRICULUM_PARTNER } from "../telemetry/constants"; | |
| import { CURRICULUM } from "../telemetry/constants"; |
client/src/curriculum/scrim.tsx
Outdated
| dialog.current?.showModal(); | ||
| setShowDialog(true); | ||
| gleanClick( | ||
| `${CURRICULUM_PARTNER}: landing_page_scrim_enter_fullscreen` |
There was a problem hiding this comment.
Suggested change
| `${CURRICULUM_PARTNER}: landing_page_scrim_enter_fullscreen` | |
| `${CURRICULUM}: scrim fullscreen -> 1` |
client/src/curriculum/scrim.tsx
Outdated
| dialog.current?.showModal(); | ||
| setShowDialog(true); | ||
| gleanClick( | ||
| `${CURRICULUM_PARTNER}: landing_page_scrim_loaded` |
There was a problem hiding this comment.
Suggested change
| `${CURRICULUM_PARTNER}: landing_page_scrim_loaded` | |
| `${CURRICULUM}: scrim engage` |
client/src/telemetry/constants.ts
Outdated
| @@ -25,6 +25,7 @@ export const PLAYGROUND = "play_action"; | |||
| export const AI_EXPLAIN = "ai_explain"; | |||
| export const SETTINGS = "settings"; | |||
| export const OBSERVATORY = "observatory"; | |||
| export const CURRICULUM_PARTNER = "curriculum_partner"; | |||
There was a problem hiding this comment.
Let's keep it simple:
Suggested change
| export const CURRICULUM_PARTNER = "curriculum_partner"; | |
| export const CURRICULUM = "curriculum"; |
client/src/curriculum/scrim.scss
Outdated
Comment on lines
11
to
16
| max-width: 24rem; | ||
| width: 100%; | ||
|
|
||
| @media (min-width: $screen-lg) { | ||
| justify-self: end; | ||
| } |
There was a problem hiding this comment.
ferdnyc
pushed a commit
to ferdnyc/yari
that referenced
this pull request
Jul 13, 2024
* feat(curriculum): update curriculum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some updates to the curriculum.