Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin to block-level math #11450

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

pepelsbey
Copy link
Member

@pepelsbey pepelsbey commented Jul 10, 2024

⚠️ There’s a PR that enforces block rendering for all block-level math. They should be merged together.

Summary

It adds margins for block-level math:

<math display="block"></math>

The same margins as <p> and <pre> have.

Problem

Block-level math, rendered outside of paragraphs, doesn’t have margins:

image

Solution

Now it does:

math[display="block"] {
  margin: 1rem 0 2rem;
}
image

@pepelsbey pepelsbey marked this pull request as ready for review July 15, 2024 15:52
@pepelsbey pepelsbey requested a review from a team as a code owner July 15, 2024 15:52
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't break anything and safe to merge even without the content PR

@pepelsbey
Copy link
Member Author

Thank you!

@pepelsbey pepelsbey merged commit 74d4712 into mdn:main Jul 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants