Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup .gitignore after PR #1573 #1989

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Fixup .gitignore after PR #1573 #1989

merged 1 commit into from
Dec 7, 2020

Conversation

bershanskiy
Copy link
Contributor

Looks like during a rebase .gitignore got extra lines showing the diff of two branches <<<<<<< HEAD, =======, >>>>>>> master. These probably should be removed.

Copy link
Contributor

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@schalkneethling schalkneethling self-assigned this Dec 7, 2020
@schalkneethling schalkneethling merged commit 35d7a09 into mdn:master Dec 7, 2020
@bershanskiy bershanskiy deleted the gitignore branch December 7, 2020 07:19
@peterbe
Copy link
Contributor

peterbe commented Dec 7, 2020

Oh noes!
We used to have tooling that prevents that from slipping in. Seems it's gone.

@bershanskiy
Copy link
Contributor Author

Do you mean something like a search for existence of lines like <<<<<<< {something}, =======, >>>>>>> {something}? That's actually a pretty neat idea!

@peterbe
Copy link
Contributor

peterbe commented Dec 8, 2020

We used to have something like that in the workflow. It did something like:

 run: git grep '<<<<<<' || (echo "looks like there are merge conflicts in there" && exit 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants