Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EXT_texture_norm16 spec #2147

Merged
merged 2 commits into from Dec 15, 2020
Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 15, 2020

Adds the spec for mdn/content#187

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 15, 2020

(side note: the CI error message is very unhelpful and there was no error locally).

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'll merge this now.

@chrisdavidmills
Copy link
Contributor

Ah wait, I can't because the commit is not signed. @peterbe is this because @Elchi3 needs to set up signature verification, a la https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/about-commit-signature-verification ?

@chrisdavidmills
Copy link
Contributor

I guess I ought to do that too, in that case

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 15, 2020

I had signed commits set up previously but forgot to do it again after I pruned my laptop. Grr.

The Yari repo has no contributing.md nor seem to mention this anywhere, fwiw.

@chrisdavidmills
Copy link
Contributor

I used to do it via SSH keys, but it looks lke GH doesn't support those any more? I'll go learn about GPG ;-)

@escattone
Copy link
Contributor

@Elchi3 So good to "see" you my friend! I'll merge this for now.

@escattone escattone merged commit 8deaa25 into mdn:master Dec 15, 2020
@Elchi3
Copy link
Member Author

Elchi3 commented Dec 15, 2020

Thank you, Ryan! ❤️ Looking forward to talking more :)

@Elchi3 Elchi3 deleted the webgl-ext-tex-norm16 branch December 15, 2020 17:03
@peterbe
Copy link
Contributor

peterbe commented Dec 15, 2020

For now, the mdn/yari repo requires signed commits but the mdn/content repo does not. Ideally, we should require it everywhere but the assumption is that there'll be a lot more people who come to mdn/content and they might not have it set up. Clearly, this is happening.
One of the risks of not requiring signed commits is security in that you might be fooled to trust a commit when you think it comes from a trusted colleague/friend when in fact it's not. That might make you merge things without looking carefully, and that actor might be sneaking things in. This is a risk factor for both repos but more so for mdn/yari because its code is directly connected to our AWS production account which ultimately can build out pages that have direct access, on the same domain, to the production database.

I think we should consider it a warning for contributors. A manual warning (ie. no GitHub PR bot).
"Hey, you should ideally use signed commits. Read here about how to set it up. It's actually easy. But I took an extra careful look at your changes and they seem perfectly fine. Thanks!"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants