Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cope with odd svg content-types #3173

Merged
merged 1 commit into from
Mar 10, 2021
Merged

cope with odd svg content-types #3173

merged 1 commit into from
Mar 10, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Mar 9, 2021

Fixes #3072

▶ curl -I https://www.w3.org/TR/2017/WD-css-timing-1-20170221/step-timing-func-examples.svg
HTTP/2 200
...
content-type: image/svg+xml; qs=0.85

Thanks to this fix I was able to fix the external images flaws in mdn/content#2982

@peterbe peterbe requested a review from fiji-flo March 9, 2021 19:01
@fiji-flo fiji-flo merged commit 0fd3272 into mdn:main Mar 10, 2021
@peterbe peterbe deleted the 3072-cope-with-odd-svg-content-types branch March 10, 2021 14:09
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
peterbe added a commit to peterbe/yari that referenced this pull request Jun 1, 2021
@peterbe
cope with odd svg content-types (mdn#3173)
0835a78 
Fixes mdn#3072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

Assignees

@fiji-flo fiji-flo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to download .svg external images because invalid file type
2 participants
@peterbe @fiji-flo