Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translate): Creating an item component の翻訳(各日本語ページリンク更新) #6757

Merged
merged 2 commits into from Jul 25, 2022

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented Jul 23, 2022

Summary

@hmatrjp @potappo

Problem

still en-us only

Solution

taranlate japanese for LearnSidebar.ejs

Before

still en-us only

After

add taranlate japanese for LearnSidebar.ejs

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jul 23, 2022
@gurezo gurezo changed the title feat(translate): 各日本語ページリンク更新 feat(translate): Creating an item component の翻訳(各日本語ページリンク更新) Jul 23, 2022
@hmatrjp
Copy link
Contributor

hmatrjp commented Jul 23, 2022

Unfortunately I don't have permission to approve to run the required check for first time contributors here,
the proposed change from gurezo looks OK for Japanese readers.

Copy link
Contributor

@potappo potappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正内容問題ありません。ありがとうございます。

LGTM Thanks!

@potappo
Copy link
Contributor

potappo commented Jul 23, 2022

it's time to poke @mdn/mdn-community-engagement

Copy link
Contributor

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gurezo and welcome to the community! 🎉

@schalkneethling
Copy link
Contributor

@gurezo for future reference, please note that this repository requires signed commits. You can read more about this requirement here: https://docs.github.com/articles/about-gpg/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants