fix(Button): pass through ARIA attrs

[LeoMcA]

• fix: pass through aira- props on Button component
• fix: improve aria labels on mobile sidebar button

Summary

fixes #8015

Problem

• Sidebar button had on aria label on it.
• It was set in the code, but as aria-label rather than ariaLabel which is the prop the Button component was expecting
• TypeScript doesn't type check any prop with a dash in it (e.g. aria-label but also foo-bar), including not checking if a component with typed props hasn't specified it as a prop it takes, so this bug was silently introduced
  • JSX prop with dash is not type checked microsoft/TypeScript#32447

Solution

• Remove our camelCase aria props on Button, and pass through all dashed props to underlying elements in Button component
  • This seemed safest as there's no way of preventing a developer adding a dashed prop, so it may continue to happen anyway
  • eslint still checks aria- props are in the right form (e.g. I mistyped aria-haspopup as aria-has-popup and got this error: aria-has-popup: This attribute is an invalid ARIA attribute. Did you mean to use aria-haspopup? jsx-a11y/aria-props)
  • if TypeScript behaviour changes, we haven't specified any dashed props in our props type, so we'll get some nice errors we can decide what to do with (either add dashed props to the type, only add aria- props, move back to camelCase aria props, etc.)
• Improve aria-label on the sidebar button, and add aria-expanded and aria-controls props

---

How did you test this change?

Clicked around in Firefox's accessibility devtools.

[caugner]

LGTM, just one question/potential nit.