feature(tool/move): update files pointing to the moved document(s) #8493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have a review on this? @claas or @LeoMcA ? #8372 proved valuable in keeping the number of flaws at bay. A few refactoring (like CSS) are ahead of us (as part of Mozilla's initiative to improve discoverability and navigability) and this feature will be needed to lower significantly the amount of menial work needed. |
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
merge conflicts 🚧
caugner
requested changes
Mar 21, 2024
There was a problem hiding this comment.
@OnkarRuikar Sorry for taking so long to get back to you.
Two requests:
- Can you please fill out the PR template, especially the Problem, Solution and "How did you test the changes?" sections?
- Also, can you fix the tests?
Thank you! 🙌
PS: Converting to draft in the mean-time.
|
Closing because this has been implemented and thoroughly tested on content side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Rename Markdown links when an internal page is moved using
yarn content move#8292Changes are almost same as Remove Markdown links in content when a page is deleted using command
yarn content delete#8372The PR:
status(new) andl10n(translated content) frontmatter attributes tooptionalFrontMatterKeysarray. Without this changeDocument.saveFile()removes these from metadata.referringFilestype from array to set in delete command. When a dirctory is deleted multiple sub pages get deleted so the array was getting duplicate entries.