Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): re-add stylelint-order #8940

Merged
merged 2 commits into from May 26, 2023
Merged

chore(lint): re-add stylelint-order #8940

merged 2 commits into from May 26, 2023

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented May 26, 2023

Summary

Problem

  • we stopped sorting css properties after ec6822f and started slowly descending into css anarchy 馃槺

Solution

How did you test this change?

Ran yarn stylelint --fix

@LeoMcA
chore(lint): re-add stylelint-order
e215d4a 
this was removed in ec6822f due to
updating stylelint-config-sass-guidelines

re-adding per bjankord/stylelint-config-sass-guidelines#278
@LeoMcA
run stylelint --fix
5b5f045
@LeoMcA LeoMcA requested a review from caugner May 26, 2023 10:45
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 26, 2023
@LeoMcA LeoMcA merged commit 3f09a66 into main May 26, 2023
15 checks passed
@LeoMcA LeoMcA deleted the stylelint-sort branch May 26, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeoMcA @caugner