fix(macro): improve webref/css v6.x.x upgrade implementation #9743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
This was referenced Sep 28, 2023
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The changes made in #9621 were not sufficient to upgrade to version 6.x.x. The structure has changed drastically so major rework is needed.
Details
The entire implementation of syntax retrieval from
@webref/csshas been done in query-css-syntax package. This helps other@webref/cssusers and will ensure easy maintenance.Testing
The code has been tested using strategy mentioned in this discussion.
yarn buildat@webref/cssv5.4.4 was compared with build using this code at v6.7.1. Apart from small changes in some syntaxes and and addition of new syntaxes all the pages rendered same.