Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure timeout updates and minor cleanup #32

Merged
merged 6 commits into from
Apr 14, 2022
Merged

Azure timeout updates and minor cleanup #32

merged 6 commits into from
Apr 14, 2022

Conversation

sseraj
Copy link
Contributor

@sseraj sseraj commented Apr 14, 2022

Purpose

I updated the timeouts in Azure and also made some minor maintenance changes:

  • Added a 10 minute time limit to the short jobs like style checks (closes Add time limit to other jobs #14)
  • Reduced the time limit for the build and test jobs from the max of 6 hours to 2 hours (motivated by recent pyAeroStructure and pyGeo PRs)
  • Removed defaults in the Tapenade subtemplate because I don't think we would ever use it outside the main template
  • Removed the SKIP_TESTS parameter which was not used and did not make much sense to keep around
  • Reordered some parameters for consistency (no functionality change)

Expected time until merged

One week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

ewu63
ewu63 approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@ewu63 ewu63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bernardopacini
bernardopacini reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@bernardopacini bernardopacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me. Just one question about the main template file.

azure/azure_template.yaml Show resolved Hide resolved
@bernardopacini bernardopacini self-requested a review April 14, 2022 22:09
@sseraj sseraj merged commit f32fb3d into main Apr 14, 2022
@sseraj sseraj deleted the timeout branch April 14, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewu63 ewu63 ewu63 approved these changes

@bernardopacini bernardopacini bernardopacini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add time limit to other jobs
3 participants
@sseraj @ewu63 @bernardopacini