Rcharayr custom mesh #353
Closed
Rcharayr custom mesh #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @RemyCharayron for opening the PR. Would you be able to briefly describe the purpose of this PR following the template we provide? (It looks you added a test for custom mesh, but it'd be great to have the note here for the record.) |
|
<div style="font-family:Arial, Helvetica, sans-serif; font-size:12px;">Hello,<br>
Initially I wanted to make a pull request on my forked repository, I made a mishandling, sorry for that. Once eveything will be okay on my forked repository and that my work will be ready for a pull request on the mdolab/OpenAeroStruct repo I will make it (using the template).<br>
<br>
Sorry again and thank you for your work on the OpenAeroStruct code,<br>
<br>
Rémy</div>
<div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">De : "Shugo Kaneko"<br>
A : "mdolab/OpenAeroStruct" ,"Rémy Charayron" ,"Mention"<br>
Envoyé: mercredi 10 Février 2021 17:12<br>
Objet : Re: [mdolab/OpenAeroStruct] Rcharayr custom mesh (#353)<br>
<div class="gl_quoted">
<p> </p>
<p>Thank you <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/RemyCharayron/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/RemyCharayron">@RemyCharayron</a> for opening the PR. Would you be able to briefly describe the purpose of this PR following the template we provide? (It looks you added a test for custom mesh, but it'd be great to have the note here for the record.)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
You are receiving this because you were mentioned.<br>
Reply to this email directly, <a href="#353 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AQ46Q27VVHBINLTFETTG3XLS6KV6FANCNFSM4XNDA7YQ">unsubscribe</a>.<img alt="" src="https://github.com/notifications/beacon/AQ46Q26NWD6RLBBZJA4ROK3S6KV6FA5CNFSM4XNDA7Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFZGV7NI.gif" width="1" height="1"></p>
</div>
</div>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Explain the goal of this PR, if it addresses an existing issue be sure to link to it. Describe the big picture of your changes here, perhaps using a bullet list if multiple changes are done to accomplish a single goal. If it accomplishes multiple goals, it would be best to create separate PR's for each.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
xin the boxes that apply.