Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py for OM reqs #357

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Update setup.py for OM reqs #357

merged 1 commit into from
Feb 20, 2021

Conversation

shamsheersc19
Copy link
Contributor

Purpose

Update setup.py to restrict OpenMDAO range.

@ewu63
Copy link
Collaborator

ewu63 commented Feb 19, 2021

Haha why did you open 3 separate PRs? Anyway let's merge this first so the other ones can pass.

@shamsheersc19
Copy link
Contributor Author

@nwu63 lol I was trying the directly editing in GitHub approach. I might be missing something, but it doesn't seem like you can edit multiple files and add them to the same branch?

@shamsheersc19 shamsheersc19 merged commit a4c34a7 into master Feb 20, 2021
@shamsheersc19 shamsheersc19 deleted the shamsheersc19-patch-3 branch February 20, 2021 00:02
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.6% when pulling f034d16 on shamsheersc19-patch-3 into cfa473c on master.

@ewu63
Copy link
Collaborator

ewu63 commented Feb 20, 2021

@nwu63 lol I was trying the directly editing in GitHub approach. I might be missing something, but it doesn't seem like you can edit multiple files and add them to the same branch?

No you can, there are two ways on the web (without using git locally)

  1. Do as you did now, and create a PR with one edit. Then go back into the same branch, edit and push directly to the same branch.
  2. Create a new branch from master, then make multiple commits directly, and make a PR at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants