-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update #389
Docs update #389
Conversation
Codecov Report
@@ Coverage Diff @@
## main #389 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 93 93
Lines 6009 6009
=======================================
Hits 5807 5807
Misses 202 202 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is a great improvement and really cleans up the code, thanks Andrew!
One question: do we have control over the output font size? It looks substantially bigger than the code or rest of the docs.
print(prob["aero_point_1.wing_perf.CL"][0]) | ||
print(prob["aero_point_1.wing_perf.CD"][0]) | ||
.. embed-code:: | ||
openaerostruct.tests.test_multipoint_aero.Test.test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also doesn't look like anything is printed out here? Is that the intended behavior if there is no :layout:
specified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can specify a layout for these if we want the output. I think I added the output manually when I went made the initial docs update. The older version of the docs didn't include the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I don't think it'd hurt given how easy it is. Anyone else have thoughts? @kanekosh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do it for now. I think the output makes it easier for people to compare their scripts when they are learning the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it’s better to print the output values here.
I agree that it's better to have the output there in the docs. I didn't comment in every place that it was missed, do you mind adding in a |
@kanekosh do you mind taking a quick look at this before we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lamkina!
Purpose
This PR uses the sphinx extensions added to
sphinx_mdolab_theme
that were originally from OpenMDAO v3.9.2. The purpose is to use these extensions to have code blocks run dynamically when we build the docs and generate necessary outputs automatically. This replaces the current static documentation format.Expected time until merged
This is a non-urgent PR and might take some time to iron out all the bugs and clean up the docs and comments in the testing code.
Type of change
Testing
The only testing for this PR is building the docs and making sure they look correct with the new extensions.
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted