Allow newest version of OpenMDAO #400

eytanadler · 2023-02-11T16:58:13Z

Purpose

Removed the upper bound on the OpenMDAO version. Because there may be changes in new OpenMDAO versions (or other packages for that matter) that break parts of OpenAeroStruct, I also added automatic GitHub Actions testing twice a month. This will tell us if any changes in the newest package versions have caused errors in OpenAeroStruct.

I've also updated black and flake8 to use the MDO Lab actions, which involved reformatting OpenAeroStruct for the new version of black.

Do we want to update the lower bound on OpenMDAO? Version 3.2.0 is getting pretty old. We aren't testing intermediate versions of packages so we don't really know that older versions still work.

Expected time until merged

Within a couple weeks?

Type of change

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (non-backwards-compatible fix or feature)
Code style update (formatting, renaming)
Refactoring (no functional changes, no API changes)
Documentation update
Maintenance update
Other (please describe)

Testing

Checklist

I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
I have run unit and regression tests which pass locally with my changes
I have added new tests that prove my fix is effective or that my feature works
I have added necessary documentation

codecov · 2023-02-11T17:44:20Z

Codecov Report

Merging #400 (ceeb22a) into main (473232a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files          93       93           
  Lines        6009     6012    +3     
=======================================
+ Hits         5806     5809    +3     
  Misses        203      203

Impacted Files	Coverage Δ
openaerostruct/aerodynamics/lift_coeff_2D.py	`100.00% <ø> (ø)`
openaerostruct/aerodynamics/mesh_point_forces.py	`100.00% <ø> (ø)`
openaerostruct/aerodynamics/pg_scale.py	`100.00% <ø> (ø)`
openaerostruct/aerodynamics/viscous_drag.py	`89.39% <ø> (ø)`
openaerostruct/common/atmos_comp.py	`100.00% <ø> (ø)`
openaerostruct/functionals/breguet_range.py	`100.00% <ø> (ø)`
openaerostruct/functionals/center_of_gravity.py	`100.00% <ø> (ø)`
openaerostruct/functionals/equilibrium.py	`100.00% <ø> (ø)`
openaerostruct/functionals/total_lift_drag.py	`100.00% <ø> (ø)`
...rostruct/geometry/geometry_mesh_transformations.py	`99.66% <ø> (ø)`
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kanekosh · 2023-02-13T14:22:55Z

Thanks @eytanadler , looks good to me!
I think we should also update the OM lower bound. Do we also want to test the oldest OM version in the Github Action by defining a matrix? E.g. Dymos does that: https://github.com/OpenMDAO/dymos/blob/master/.github/workflows/dymos_tests_workflow.yml

I personally wouldn't bother testing it because it doubles the build time, but I'm okay either way.

eytanadler · 2023-02-13T15:09:40Z

Thanks @eytanadler , looks good to me! I think we should also update the OM lower bound. Do we also want to test the oldest OM version in the Github Action by defining a matrix? E.g. Dymos does that: https://github.com/OpenMDAO/dymos/blob/master/.github/workflows/dymos_tests_workflow.yml

I personally wouldn't bother testing it because it doubles the build time, but I'm okay either way.

I'll add a test for older OM versions. I believe GHA runs the build matrix in parallel, so it shouldn't slow it down much. On second thought, I guess if the version works there's no point in updating it since leaving as is will enable pip to resolve versions more easily if there are dependency conflicts.

…for debugging

…save debugging time

…only package difference between working and not

…elf be defeated

eytanadler · 2023-02-14T01:57:30Z

@kanekosh @bernardopacini I think this is finally ready for review. The GHA build file isn't the prettiest thing you'll ever see, but it does the job it needs to.

kanekosh

Thank you Eytan! Other than the pygeo version in setup.py, looks good to me

kanekosh · 2023-02-14T14:24:09Z

setup.py

@@ -11,7 +11,7 @@
 optional_dependencies = {
    "docs": ["sphinx_mdolab_theme"],
    "test": ["pytest", "pytest-cov", "coverage"],
-    "ffd": ["pygeo>=1.6.0"]
+    "ffd": ["pygeo>=1.6.0"],


pygeo>=1.12.2 ?

Good catch. pyGeo 1.12.2 was the latest that works with the old versions of the other packages, but older versions of pyGeo work too. I'll see if 1.6.0 works with the old build and if so leave that as the old build version.

bernardopacini

One minor comment, but overall looks good to me!

bernardopacini · 2023-02-15T20:46:42Z

openaerostruct/docs/installation.rst

+      - latest
+    * - OpenVSP (optional)
+      - 3.27.1
+      - 3.27.1


Is this duplicate by mistake?

This is intentional since the OpenVSP version is 3.27.1 on both the oldest and latest GitHub Actions builds

Removed upper bound on OM version added bi-monthly scheduled tests

e7978ca

eytanadler requested a review from a team as a code owner February 11, 2023 16:58

eytanadler requested review from kanekosh and bernardopacini February 11, 2023 16:58

eytanadler added 3 commits February 11, 2023 12:25

Update to Python 3.10 for GHA and use MDO Lab flake8 and black tests

2c95c61

Formatted for new version of black

59038a9

Moved flake8 OAS config file so MDO Lab action will pick it up

89b5890

eytanadler added 3 commits February 11, 2023 12:59

Trying to make flake8 happy

42106c2

More flake8 changes

36a988c

Whoops I messed up one of the tests

9b13a32

eytanadler added 17 commits February 13, 2023 10:50

Test oldest package versions in GHA build

09bad9d

Fixing bugs in GHA file

479384c

More bugs with quotation marks

241fc21

Updated oldest OM version and bumped patch version of OAS

07f5f37

Try older pytest version to fix seg fault in GHA

510428f

Try newer Python version for oldest and get rid of OpenVSP and pyGeo …

b964373

…for debugging

Try back to 3.8

6859063

Add in pySpline and pyGeo

6acb581

Broke with pySpline/pyGeo, try only OpenVSP

7031de2

See if OpenVSP is changing the numpy version

93c6956

Trying an older vsp version so numpy doesn't update

54542f3

Try installing OpenVSP before OAS and other deps

95d9da3

Add back in pySpline and pyGeo....*gulp*

3986581

Move pySpline/Geo install to after OAS install since it needs numpy

a5adbc1

The error returns.....see if it can be reproduced without OpenVSP to …

d951b4c

…save debugging time

Does Python 3.9 work

f857113

Try Python 3.10, otherwise it's a package issue

7d37866

eytanadler added 20 commits February 13, 2023 15:46

See if working build on Python 3.10 works with older setuptools, the …

9561e07

…only package difference between working and not

Python version is the problem, try 3.9 again

94fe175

See if Python 3.11 works just for fun

886901b

Does it really work fine without pygeo, wtf matplotlib...

78e0055

How about an older matplotlib

8f74bc1

Try an older version of pyGeo

a088e00

Fixed type in GHA build file

e817c0d

Changed name to specify pygeo version

a5af0aa

Try pyGeo v1.12.0

b4fd6e7

pyGeo 1.12.0 seems to work, try 1.12.1

34ecc61

pyGeo 1.12.1 seems to work, try 1.12.2

d20fe8d

pyGeo 1.12.2 seems to work, try latest again

889cd88

Revert back to pyGeo 1.12.2 for the old build

db38cd9

Get rid of tagged matplotlib version

eb45ef2

Add back in OpenVSP

f45465a

Cleaning up the YAML file

f782fd2

Kinda abusing the build matrix but whatchagonnado

3fa801e

gabagool

1111732

Maya Angelou: You will face many defeats in life, but never let yours…

5690e82

…elf be defeated

New table for RTD

a358f1b

kanekosh requested changes Feb 14, 2023

View reviewed changes

eytanadler added 3 commits February 14, 2023 09:58

pyGeo v1.6.0 on oldest build

4aec20c

Does pyGeo error go away if I install OAS in place

331c77f

Go back to working build with pyGeo 1.6.0 and update docs

ceeb22a

eytanadler requested a review from kanekosh February 14, 2023 18:03

kanekosh approved these changes Feb 14, 2023

View reviewed changes

bernardopacini approved these changes Feb 15, 2023

View reviewed changes

eytanadler merged commit 71045b3 into mdolab:main Feb 15, 2023

eytanadler deleted the update_om branch February 15, 2023 20:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow newest version of OpenMDAO #400

Allow newest version of OpenMDAO #400

eytanadler commented Feb 11, 2023 •

edited

codecov bot commented Feb 11, 2023 •

edited

kanekosh commented Feb 13, 2023

eytanadler commented Feb 13, 2023

eytanadler commented Feb 14, 2023

kanekosh left a comment

kanekosh Feb 14, 2023

eytanadler Feb 14, 2023

bernardopacini left a comment

bernardopacini Feb 15, 2023

eytanadler Feb 15, 2023

Allow newest version of OpenMDAO #400

Allow newest version of OpenMDAO #400

Conversation

eytanadler commented Feb 11, 2023 • edited

Purpose

Expected time until merged

Type of change

Testing

Checklist

codecov bot commented Feb 11, 2023 • edited

Codecov Report

kanekosh commented Feb 13, 2023

eytanadler commented Feb 13, 2023

eytanadler commented Feb 14, 2023

kanekosh left a comment

Choose a reason for hiding this comment

kanekosh Feb 14, 2023

Choose a reason for hiding this comment

eytanadler Feb 14, 2023

Choose a reason for hiding this comment

bernardopacini left a comment

Choose a reason for hiding this comment

bernardopacini Feb 15, 2023

Choose a reason for hiding this comment

eytanadler Feb 15, 2023

Choose a reason for hiding this comment

eytanadler commented Feb 11, 2023 •

edited

codecov bot commented Feb 11, 2023 •

edited