Input file fix #123
Input file fix #123
Conversation
marcomangano
requested review from
joanibal,
Xiaosong2105,
ewu63 and
eirikurj
|
@marcomangano did you also include the new cgns files for your rotation tests? |
input_files/get-input-files.sh
Outdated
| @@ -4,4 +4,4 @@ | |||
|
|
|||
| DIR=$(dirname $0) | |||
| wget -O $DIR/input_files.tar.gz http://umich.edu/~mdolaboratory/repo_files/ADflow/adflow_input_files.tar.gz | |||
| tar -xzf $DIR/input_files.tar.gz -C $DIR/../ | |||
| tar -xzf $DIR/input_files.tar.gz -C $DIR | |||
There was a problem hiding this comment.
Seems that the new file is a tarbomb. I personally think we should refrain from that types of behavior.
There was a problem hiding this comment.
Yeah okay that's fair, I just didn't like relying on the name of the directory stored in the tarball instead of the parent directory of the get-input-files.sh script when extracting, since it's harder to be consistent.
There was a problem hiding this comment.
Oh really? Do you prefer to place a subfolder in the input_files folder?
There was a problem hiding this comment.
I thought it was safe because we were already opening it into a separate folder
There was a problem hiding this comment.
I think Eirikur is in general against tarbombs which is fair, although in this case the script specifically extracts to a designated directory.
Yes! |
Purpose
Closes #122 . I uploaded on
mfilea newtar.gzfolder without subfolders, and changed the download bash script to untar directly intoinput_files. All the tests have been updated to point to this folder.Note: the new
tar.gzalso includes a new.cgnsfile used for the rotating frame adjoint test added with #121Type of change
Testing
The tests have been checked locally.
Checklist
flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted