Time spectral with flexible grid #169

SichengHe · 2021-10-14T23:54:10Z

Purpose

The commit is related to time spectral with a flexible grid. It also contains a simple 2D regression test case.

Type of change

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (non-backwards-compatible fix or feature)
Code style update (formatting, renaming)
Refactoring (no functional changes, no API changes)
Documentation update
Maintenance update
Other (please describe)

Testing

Checklist

I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
I have run unit and regression tests which pass locally with my changes
I have added new tests that prove my fix is effective or that my feature works
I have added necessary documentation

…eration

…eriod.

…int)

codecov · 2021-10-15T00:17:57Z

Codecov Report

Merging #169 (5e2ee2b) into master (08f431a) will decrease coverage by 15.07%.
The diff coverage is 45.45%.

❗ Current head 5e2ee2b differs from pull request most recent head 49b2c5e. Consider uploading reports for the commit 49b2c5e to get more accurate results

@@             Coverage Diff             @@
##           master     #169       +/-   ##
===========================================
- Coverage   42.74%   27.66%   -15.08%     
===========================================
  Files          15       15               
  Lines        3495     3502        +7     
===========================================
- Hits         1494      969      -525     
- Misses       2001     2533      +532

Impacted Files	Coverage Δ
adflow/pyADflow.py	`42.34% <45.45%> (-24.77%)`	⬇️
adflow/MExt.py	`79.48% <0.00%> (-17.95%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f431a...49b2c5e. Read the comment docs.

sseraj

I will review the code soon, but I wanted to comment on the options

adflow/pyADflow.py

sseraj

Overall this looks fine, but I would like some clarification on the following points

adflow/pyADflow.py

src/solver/solverUtils.F90

sseraj · 2021-11-05T03:51:53Z

src/solver/solverUtils.F90

+  end subroutine gridVelocitiesFineLevel_TS
+#endif
+
+  subroutine gridVelocitiesFineLevel_TS_block(nn, sps)


Should there be AD code for this like there is for gridVelocitiesFineLevel_block?

Yes. It is in my branch and will be pushed.

I was going to make the same comment. I don't see the AD'd version of this subroutine in this PR.

tests/reg_tests/test_time_spectral_naca64A010.py

adflow/pyADflow.py

doc/options.yaml

src/solver/solverUtils.F90

adflow/pyADflow.py

SichengHe · 2021-11-13T19:53:03Z

Could we merge now? Do I need to do anything else? @sseraj @marcomangano

anilyil · 2021-11-13T19:54:43Z

I haven't reviewed this yet; I wasn't sure if it was ready or not. Can you give me a few days to review this?

SichengHe · 2021-11-13T20:04:38Z

@anilyil Sounds good. Thanks!

marcomangano · 2021-11-13T22:44:32Z

I assume the test will keep failing until we fix the issue with Azure, so we can ignore it for now. I don't have additional recommendations, but I will let the experts review this!

anilyil

Hi, sorry for the delay. I left a few comments. Thanks!

src/f2py/adflow.pyf

anilyil · 2021-11-17T15:23:03Z

src/solver/solverUtils.F90

+  end subroutine gridVelocitiesFineLevel_TS
+#endif
+
+  subroutine gridVelocitiesFineLevel_TS_block(nn, sps)


I was going to make the same comment. I don't see the AD'd version of this subroutine in this PR.

tests/reg_tests/test_time_spectral_naca64A010.py

ewu63 · 2021-12-01T20:49:06Z

@SichengHe please take a look at the reviewer comments

sseraj · 2021-12-10T16:36:08Z

I think the only thing still left to do here is to add the AD code?

SichengHe · 2021-12-11T02:42:06Z

@sseraj Could we actually merge this first? I am planning to create another PR for the ADed code later this month.

anilyil · 2021-12-13T02:28:58Z

adding the AD code later is fine for me. @sseraj up to you if you want the AD code in this PR. Otherwise this is good to go for me

marcomangano · 2021-12-16T15:43:25Z

@sseraj @SichengHe what is the decision then? Shall we wait for the ADed code, or shall we move on and merge this?

sseraj

I would prefer to have the AD code in the same PR but I am fine with merging this to avoid the PR getting stale.

SichengHe and others added 7 commits October 14, 2021 10:54

2D flutter analysis working

7deb251

remove unnecessary commit

492de0b

removed the change of mach grid; made the change due to dcl/dx consid…

ad1cda5

…eration

remove the dependency on the stability staff to initialize the time p…

8b956f5

…eriod.

revoke a unnecssary fix in tecplotIO (maybe useful later for the adjo…

62ffb76

…int)

add regression test

9096e99

modified the test case

a65ca11

Sicheng He and others added 3 commits October 27, 2021 17:05

add TS regression test

3d30335

clean things a bt

a66b482

Merge branch 'mdolab:master' into timespectral_merge

0048bdf

SichengHe marked this pull request as ready for review October 28, 2021 18:27

SichengHe requested a review from a team as a code owner October 28, 2021 18:27

SichengHe requested review from marcomangano and sseraj October 28, 2021 18:27

flake8 and black format fiix

e48ec3b

sseraj reviewed Oct 29, 2021

View reviewed changes

adflow/pyADflow.py Outdated Show resolved Hide resolved

SichengHe mentioned this pull request Oct 29, 2021

Add timespectral tests #141

Closed

Sicheng He and others added 3 commits October 31, 2021 21:23

minor fix

49947cd

minor fix for the doc

c3227f8

more minor fix for doc

58a0e7a

sseraj reviewed Nov 5, 2021

View reviewed changes

sseraj changed the title ~~Timespectral merge~~ Time spectral with flexible grid Nov 5, 2021

fixes for issue mentioned by Sabet

dbc8f65

sseraj reviewed Nov 5, 2021

View reviewed changes

adflow/pyADflow.py Show resolved Hide resolved

SichengHe added 2 commits November 11, 2021 15:05

minor fix for options

5a6f4a9

more option fix

ff9cd89

anilyil self-requested a review November 13, 2021 19:54

anilyil reviewed Nov 17, 2021

View reviewed changes

SichengHe added 2 commits December 9, 2021 13:09

Merge branch 'mdolab:master' into timespectral_merge

a0b5185

remove use from pyf file

49b2c5e

anilyil requested review from sseraj and anilyil December 13, 2021 02:28

anilyil approved these changes Dec 13, 2021

View reviewed changes

sseraj approved these changes Dec 16, 2021

View reviewed changes

sseraj merged commit f870d03 into mdolab:master Dec 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Time spectral with flexible grid #169

Time spectral with flexible grid #169

SichengHe commented Oct 14, 2021 •

edited

Loading

codecov bot commented Oct 15, 2021 •

edited

Loading

sseraj left a comment

sseraj left a comment

sseraj Nov 5, 2021

SichengHe Nov 5, 2021

anilyil Nov 17, 2021

SichengHe commented Nov 13, 2021

anilyil commented Nov 13, 2021

SichengHe commented Nov 13, 2021

marcomangano commented Nov 13, 2021

anilyil left a comment

anilyil Nov 17, 2021

ewu63 commented Dec 1, 2021

sseraj commented Dec 10, 2021

SichengHe commented Dec 11, 2021

anilyil commented Dec 13, 2021

marcomangano commented Dec 16, 2021

sseraj left a comment

Time spectral with flexible grid #169

Time spectral with flexible grid #169

Conversation

SichengHe commented Oct 14, 2021 • edited Loading

Purpose

Type of change

Testing

Checklist

codecov bot commented Oct 15, 2021 • edited Loading

Codecov Report

sseraj left a comment

Choose a reason for hiding this comment

sseraj left a comment

Choose a reason for hiding this comment

sseraj Nov 5, 2021

Choose a reason for hiding this comment

SichengHe Nov 5, 2021

Choose a reason for hiding this comment

anilyil Nov 17, 2021

Choose a reason for hiding this comment

SichengHe commented Nov 13, 2021

anilyil commented Nov 13, 2021

SichengHe commented Nov 13, 2021

marcomangano commented Nov 13, 2021

anilyil left a comment

Choose a reason for hiding this comment

anilyil Nov 17, 2021

Choose a reason for hiding this comment

ewu63 commented Dec 1, 2021

sseraj commented Dec 10, 2021

SichengHe commented Dec 11, 2021

anilyil commented Dec 13, 2021

marcomangano commented Dec 16, 2021

sseraj left a comment

Choose a reason for hiding this comment

SichengHe commented Oct 14, 2021 •

edited

Loading

codecov bot commented Oct 15, 2021 •

edited

Loading