Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py with allowed numpy version #281

Merged
merged 3 commits into from
Apr 30, 2023
Merged

Update setup.py with allowed numpy version #281

merged 3 commits into from
Apr 30, 2023

Conversation

eirikurj
Copy link
Contributor

Purpose

Numpy just released 1.24.3, so issues described in #256 should be addressed. The setup.py now excludes the problematic 1.24 versions, but should permit everything above 1.16. If we know of other versions, we should add them also.

Closes #256

Expected time until merged

No rush.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner April 23, 2023 16:31
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #281 (f63d7e5) into main (83507a8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   40.87%   40.87%           
=======================================
  Files          13       13           
  Lines        3892     3892           
=======================================
  Hits         1591     1591           
  Misses       2301     2301           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anilyil anilyil self-requested a review April 30, 2023 02:02
@anilyil anilyil merged commit b97914b into main Apr 30, 2023
@anilyil anilyil deleted the updateNumpy branch April 30, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADflow doesn't work with numpy 1.24
4 participants