-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Tapenade 3.16 #312
Conversation
Codecov Report
@@ Coverage Diff @@
## main #312 +/- ##
=======================================
Coverage 41.98% 41.98%
=======================================
Files 13 13
Lines 4001 4001
=======================================
Hits 1680 1680
Misses 2321 2321 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the updated build process and ran derivative checks with simple test cases and a MACH-only version of my aeroprop case. Derivatives look good and the tapenade build worked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested this on my side and everything looks good
Purpose
This PR updates the AD'd files to the latest Tapenade version along with the latest ADFirstAidKit files.
Few things to note, regarding this version of Tapenade. This version creates nonstandard type declarations, so postprocessing steps are added in
autoEdit
scripts. Additionally, Tapenade seems for some reason to miss theetot_d
function ininviscidupwindflux_d
(same for reverse) so its added back.Please review carefully and preferably run and test this on actual cases (aside from the unit/regression tests) to make sure derivatives have not regressed in some edge cases.
Expected time until merged
No rush
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable