Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Tapenade 3.16 #312

Merged
merged 18 commits into from
Sep 13, 2023
Merged

Update to Tapenade 3.16 #312

merged 18 commits into from
Sep 13, 2023

Conversation

eirikurj
Copy link
Contributor

Purpose

This PR updates the AD'd files to the latest Tapenade version along with the latest ADFirstAidKit files.

Few things to note, regarding this version of Tapenade. This version creates nonstandard type declarations, so postprocessing steps are added in autoEdit scripts. Additionally, Tapenade seems for some reason to miss the etot_d function in inviscidupwindflux_d (same for reverse) so its added back.

Please review carefully and preferably run and test this on actual cases (aside from the unit/regression tests) to make sure derivatives have not regressed in some edge cases.

Expected time until merged

No rush

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner August 28, 2023 14:35
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #312 (8bf7aab) into main (686d096) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files          13       13           
  Lines        4001     4001           
=======================================
  Hits         1680     1680           
  Misses       2321     2321           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lamkina lamkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the updated build process and ran derivative checks with simple test cases and a MACH-only version of my aeroprop case. Derivatives look good and the tapenade build worked as expected.

Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested this on my side and everything looks good

@marcomangano marcomangano merged commit 4cfc3c1 into main Sep 13, 2023
17 checks passed
@marcomangano marcomangano deleted the updateTapenade branch September 13, 2023 18:53
@ewu63 ewu63 mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants