-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MPhys builder options for residual scaling and solution writing #332
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 41.52% 41.46% -0.07%
==========================================
Files 13 13
Lines 4058 4064 +6
==========================================
Hits 1685 1685
- Misses 2373 2379 +6 ☔ View full report in Codecov by Sentry. |
adflow/mphys/mphys_adflow.py
Outdated
balance_group : ???, optional | ||
???, by default None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go now I believe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Doesn't touch anything outside of the residual scaling so nicely contained. LGTM
Purpose
Adds two new options to the ADflowBuilder class:
write_solution
to allow disabling of automatic solution file writingres_ref
to specify a reference residual value that will be used by OpenMDAO to scale the residualWarning: as explained in OpenMDAO/OpenMDAO#3072 OpenMDAO doesn't currently apply the residual scaling correctly to matrix-free partial derivatives, so any
check_partials
currently fails if you do any residual scaling. The total derivatives are fine though.ToDo before merging
get_tagged_indices
method toADflowBuilder
#298balance_group
builder argumentExpected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable