-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating orange hex #15
Conversation
I see the tests fail, these aren't lines I changed but I can run the formatter and update them for this PR. |
Hey Jenna, thanks for pointing this out, I'd never noticed. I like the new orange but it is now a little close to the yellow/gold colour, although definitely not as close as the previous version was to red (see below). Can we tweak the orange ever so slightly so that it's a bit more distinct? I would like to keep the old orange as I think it's a nice colour, but I'll rename it |
I was unable to reproduce the errors locally, but changed the files based on the GH log. This now directly conflicts with local black, but should pass the checks on GH. |
It is similar, you're right. We could try making the orange lighter, such as |
Ugh, I dunno what's happening with the formatting, will fix tomorrow |
Unlike the checks in Azure, the YAML file doesn't specify the version of |
Purpose
The goal of this PR is to resolve issue #14, replacing the current orange with
#ff7f0e
.Type of change
Testing
N / A
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted