-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added active thermal components and usage examples #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added thermal components SimpleHeatPump and SimpleTMS
…eriesHybridElectricPropulsionRefrigerated
…dTwin_active_thermal not yet converging
…roved HybridTwin_active_thermal convergence
Change temp setpoints in hybrid twin with refrig
…thermal and HybridTwin_active_thermal
Pull Request Test Coverage Report for Build 177
💛 - Coveralls |
bbrelje
requested changes
Aug 10, 2020
draft_heatengine_test.py
Outdated
@@ -0,0 +1,13 @@ | |||
import openmdao.api as om |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file is probably a candidate to be deleted - maybe committed by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, just removed it
bbrelje
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This change adds active thermal components to OpenConcept. Additionally, components to help better interface the new components with aircraft models and usage examples have been added. The following components and examples are the notable additions:
SimpleHeatPump
in thermal.py: heat pump with efficiency based on fraction of Carnot efficiencyHeatPumpWithIntegratedCoolantLoop
in thermal.py:SimpleHeatPump
integrated into hot side and cold side coolant heat transfer components for easy integration directly into coolant loopsTwinSeriesHybridElectricPropulsionRefrigerated
in thermal_series_hybrid.py: an example ofHeatPumpWithIntegratedCoolantLoop
implemented into a propulsion model to add active cooling for the battery and electric motorTo implement the above, general purpose utilities were added. Of the ones added, the following are the most generally useful:
SelectorComp
in selector.py: takes in any number of user-specified inputs and routes one to the single output depending on the value of the selector input; used to control the refrigerator bypassMaxComp
andMinComp
in max_min_comp.py: takes a vector input and returns a scalar output that is the max/min of the inputType of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Tests have been added for the new components and an integration test was added for the new example aircraft,
HybridTwin_active_thermal
.Checklist
Put an
x
in the boxes that apply.