Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added active thermal components and usage examples #20

Merged
merged 35 commits into from
Aug 11, 2020

Conversation

eytanadler
Copy link
Collaborator

Purpose

This change adds active thermal components to OpenConcept. Additionally, components to help better interface the new components with aircraft models and usage examples have been added. The following components and examples are the notable additions:

  • SimpleHeatPump in thermal.py: heat pump with efficiency based on fraction of Carnot efficiency
  • HeatPumpWithIntegratedCoolantLoop in thermal.py: SimpleHeatPump integrated into hot side and cold side coolant heat transfer components for easy integration directly into coolant loops
  • TwinSeriesHybridElectricPropulsionRefrigerated in thermal_series_hybrid.py: an example of HeatPumpWithIntegratedCoolantLoop implemented into a propulsion model to add active cooling for the battery and electric motor
  • HybridTwin_active_thermal.py: an example of the refrigerated propulsion system integrated into a working aircraft model; shows usage of the hot and cold side set temperatures along with the refrigerator bypass switch to control the refrigerator

To implement the above, general purpose utilities were added. Of the ones added, the following are the most generally useful:

  • SelectorComp in selector.py: takes in any number of user-specified inputs and routes one to the single output depending on the value of the selector input; used to control the refrigerator bypass
  • MaxComp and MinComp in max_min_comp.py: takes a vector input and returns a scalar output that is the max/min of the input

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • New feature (non-breaking change which adds functionality)

Testing

Tests have been added for the new components and an integration test was added for the new example aircraft, HybridTwin_active_thermal.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

bbrelje and others added 30 commits June 29, 2020 22:12
Added thermal components SimpleHeatPump and SimpleTMS
Change temp setpoints in hybrid twin with refrig
@eytanadler eytanadler requested a review from a team as a code owner August 7, 2020 20:58
@coveralls
Copy link

coveralls commented Aug 7, 2020

Pull Request Test Coverage Report for Build 177

  • 301 of 301 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 87.538%

Totals Coverage Status
Change from base Build 174: 0.9%
Covered Lines: 3730
Relevant Lines: 4261

💛 - Coveralls

@@ -0,0 +1,13 @@
import openmdao.api as om
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is probably a candidate to be deleted - maybe committed by mistake?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, just removed it

@bbrelje bbrelje merged commit 4ce3423 into mdolab:master Aug 11, 2020
@eytanadler eytanadler deleted the heatengine branch August 16, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants