-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to Github Actions #26
Conversation
Pull Request Test Coverage Report for Build 570172305
💛 - Coveralls |
Addresses issue #24. |
Testing with Github Actions is up and running besides the push to Coveralls. @bbrelje Do you remember how you set that up originally? Do we need to reset the repo on Coveralls for it to recognize Github Actions instead of Travis? EDIT: Fixed (see below) |
Fixed coveralls push by switching to |
Before merging, Travis should be removed and Github Actions should be set as the required check. I do not believe I have access to make this change. Also, AppVeyor is failing because it uses the wrong version of OpenMDAO (3.7 as opposed to 3.2.1). Do we want to fix this and continue using AppVeyor or remove it to rely on Github Actions? |
Fixed AppVeyor by pinning OpenMDAO version (3.2.1). Github Actions can test on Windows. Do we want to continue running AppVeyor or consolidate to Github Actions with two stages, one for linux and one for windows? |
I would prefer to pin the version in I'm also ambivalent regarding AppVeyor, though if we can do exactly the same in GA I guess that would be nice. EDIT: I see that |
@bbrelje I am thinking of moving all of the required packages (besides coverage-related ones) into the |
Any idea where the |
I think |
Right thank you! We probably want to do |
Sorry for the excessive commits, after a really long time I figured out that for miniconda to work we had to set |
Purpose
This change adds Github Actions and removes Travis testing. The Github Actions configuration file is in
.github/workflows/
. Also, this change pins the OpenMDAO version inrequirements.txt
to match the one tested in travis, the latest version fails the tests.Type of change
This is a maintenance update.
Select the appropriate type(s) that describe this PR
X Other (please describe)
Testing
Tests pass on personal fork, push to coveralls not tested yet (must come from MDOLab repo).
Checklist
Put an
x
in the boxes that apply.