Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of new thermal components, engine decks, updates for new OpenMDAO, and more #31

Merged
merged 129 commits into from
Nov 2, 2021

Conversation

eytanadler
Copy link
Collaborator

Purpose

This PR adds a host of new thermal components including an improved refrigerator, heat pipes, and flow splitters. It also includes engine models for the CFM56, a representative N+3 turbofan, and a parallel hybrid N+3 turbofan. Many components have been updated to function better with more recent versions of OpenMDAO and more unit/regression tests have been added.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

bbrelje and others added 30 commits August 17, 2020 22:08
…ic derivatives and create a full duct model that can take an external HX model as connections
@eytanadler eytanadler requested a review from a team as a code owner October 27, 2021 21:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1391999426

  • 1030 of 1540 (66.88%) changed or added relevant lines in 21 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.3%) to 86.147%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openconcept/analysis/trajectories.py 44 45 97.78%
openconcept/components/cfm56.py 3 5 60.0%
openconcept/components/heat_pipe.py 201 203 99.01%
openconcept/components/heat_exchanger.py 11 14 78.57%
openconcept/components/ducts.py 155 160 96.88%
openconcept/utilities/dict_indepvarcomp.py 3 21 14.29%
openconcept/components/heat_sinks.py 251 273 91.94%
openconcept/utilities/visualization.py 1 41 2.44%
openconcept/analysis/performance/dymos_phases.py 0 152 0.0%
openconcept/components/N3.py 75 340 22.06%
Totals Coverage Status
Change from base Build 611745095: -1.3%
Covered Lines: 4546
Relevant Lines: 5277

💛 - Coveralls

Copy link

@hajdik hajdik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hajdik hajdik merged commit 6a07714 into mdolab:master Nov 2, 2021
@eytanadler eytanadler deleted the merge37 branch January 19, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants