Fixed heat exchanger coefficient used for pressure drop #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 80.27% 80.28%
=======================================
Files 84 84
Lines 8970 8974 +4
=======================================
+ Hits 7201 7205 +4
Misses 1769 1769
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There was a mistake in the heat exchanger
PressureDropcomponent where the cold side coefficients were used also for the hot side, instead of the hot side coefficients. I don't think this will affect anything since the default option values for the cold and hot sides are the same and are rarely specified to be something else (never in the code as far as I can tell).Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR