Changed Hx Value error to Analysis error for 3 instances. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eytanadler
requested review from
eytanadler
and removed request for
kanekosh and
bernardopacini
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 79.95% 79.98% +0.03%
==========================================
Files 85 85
Lines 9300 9300
==========================================
+ Hits 7436 7439 +3
+ Misses 1864 1861 -3 ☔ View full report in Codecov by Sentry. |
eytanadler
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Thank you Marie! Let's get #61 merged first, then we can merge this one and make a new release for version 1.1.2.
kanekosh
reviewed
Feb 14, 2024
There was a problem hiding this comment.
@mariejvaucher Could you fix the conflicts in the import lines? Other than that, looks good to me.
kanekosh
approved these changes
Mar 5, 2024
eytanadler
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously the script was raising a Python ValueError that wasn't caught by OM solvers. Now the error is an OM Analysis Error which allows the solver to continue optimization and also gives details about which value is wrong and why.
Type of change
Testing
Added new tests
Checklist
Put an
xin the boxes that apply.