-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix Windows build in GHA #328
Conversation
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
=======================================
Coverage 84.22% 84.22%
=======================================
Files 22 22
Lines 3340 3340
=======================================
Hits 2813 2813
Misses 527 527 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
96acf08
to
920ba38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure I approved after your last commit.. anyway, this is good for me. @ArshSaja please double-check and merge when you have time
Looks good to me! |
Purpose
The windows build failed in #327, this is a PR to fix that. I found conda-incubator/setup-miniconda#275 which directed me to conda-incubator/setup-miniconda#274 which contained a workaround that should work.
Expected time until merged
Whenever
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable