Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix Windows build in GHA #328

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Attempt to fix Windows build in GHA #328

merged 7 commits into from
Feb 21, 2023

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Feb 20, 2023

Purpose

The windows build failed in #327, this is a PR to fix that. I found conda-incubator/setup-miniconda#275 which directed me to conda-incubator/setup-miniconda#274 which contained a workaround that should work.

Expected time until merged

Whenever

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner February 20, 2023 23:58
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #328 (920ba38) into main (bc71de9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   84.22%   84.22%           
=======================================
  Files          22       22           
  Lines        3340     3340           
=======================================
  Hits         2813     2813           
  Misses        527      527           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

marcomangano
marcomangano previously approved these changes Feb 21, 2023
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure I approved after your last commit.. anyway, this is good for me. @ArshSaja please double-check and merge when you have time

@ArshSaja
Copy link
Contributor

Looks good to me!

@ArshSaja ArshSaja merged commit 21a4f67 into main Feb 21, 2023
@marcomangano marcomangano deleted the fix-windows-build branch February 21, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants